Skip to content

fix(reviewer): claiming/unclaiming for ship review#305

Merged
dhamariT merged 6 commits into
hackclub:mainfrom
ObayM:fixing-claiming-sw
Jun 3, 2026
Lines changed: 118 additions & 24 deletionsions
Merged

fix(reviewer): claiming/unclaiming for ship review#305
dhamariT merged 6 commits into
hackclub:mainfrom
ObayM:fixing-claiming-sw

Conversation

@ObayM
Copy link
Copy Markdown
Contributor

@ObayM ObayM commented Jun 2, 2026

what's this do?

Adds a way to unclaim your review, fixed the claim functionality as it was resetting the TTL on every page load which was very buggy and might be confusing to shipwrights, it's now a hard 30-minute lock from when you claimed it :)
Note: The UI is will have a rework. It is currently unpolished as it is not a priority for noww

show it works

image

ai?

Claude

@maxwofford
Copy link
Copy Markdown
Member

@ObayM this doesn't feel very railsy. i'd encourage asking your claude "how to make claim / unclaim pretend to be a CRUD action"

@ObayM
Copy link
Copy Markdown
Contributor Author

ObayM commented Jun 3, 2026

@maxwofford Thanks for the suggestion :)
Refactored claim/unclaim into a dedicated Admin::Certification::Ships::ClaimsController with create (claim) and destroy (unclaim), nested under one resource :claim

I was initially under the impression that custom actions (post :claim) was the correct pattern in the codebase, so I went with it, but it's now much cleaner :)

@dhamariT dhamariT added this pull request to the he merge queue Jun 3, 2026
Merged via the queue into hackclub:main with commit t 1d1f503 Jun 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

3 participants