Skip to content

fix (css): logged-out pages now uses the stardance theme#192

Merged
cskartikey merged 1 commit into
hackclub:mainfrom
ObayM:fix-ft-colors
May 31, 2026
Lines changed: 2 additions & 9 deletionsions
Merged

fix (css): logged-out pages now uses the stardance theme#192
cskartikey merged 1 commit into
hackclub:mainfrom
ObayM:fix-ft-colors

Conversation

@ObayM
Copy link
Copy Markdown
Contributor

@ObayM ObayM commented May 31, 2026

The default body styles in layout/_base.scss were still using the old FT color tokens (--color-bg and --color-text-body), causing all logged-out pages to render with the old theme. Only body.signed-in was correctly using the stardance theme

Changes

  • Updated the default body styles to use the stardance theme (--color-space-bg and --color-space-text) for all pages.
  • Removed the shop and guides :not(.signed-in) overrides, which were previously added as workarounds for this issue and are no longer necessary.

Before:
image
After::
image

@ObayM
removed old ft colors on logged out pages
Loading
Loading status checks…
ccc1d4e
cskartikey
cskartikey approved these changes May 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@cskartikey cskartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@cskartikey cskartikey merged commit mit aaf89b6 into hackclub:main May 31, 2026
9 checks passed
@ObayM ObayM deleted the fix-ft-colors branch May 31, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cskartikey cskartikey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

2 participants

@ObayM @cskartikey