Skip to content

feat(projects): add re-certification flow for returned ships#442

Merged
dhamariT merged 4 commits into
hackclub:mainfrom
ObayM:sw-recertification
Jun 8, 2026
Merged

feat(projects): add re-certification flow for returned ships#442
dhamariT merged 4 commits into
hackclub:mainfrom
ObayM:sw-recertification

Conversation

@ObayM

@ObayM ObayM commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

what's this do?

Once a project was returned with changes requested, there was no way to re-submit it for certification.

So now the "Changes requested" badge on ship cards is now a clickable button that opens a modal displaying the shipwright's proof video, feedback, and a "Request re-certification" button :)

Requesting re-certification resets the ship event's certification_status back to "pending" :)

show it works

image

ai?

Claude

@dhamariT

dhamariT commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This looks good. One tiny non blocking thing. the pending review check here runs before the lock so if anyone with iffy wifi double click it. two request can hit the server at the same time. You should move the check inside the lock so it actually guardss!

@ObayM

ObayM commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

This looks good. One tiny non blocking thing. the pending review check here runs before the lock so if anyone with iffy wifi double click it. two request can hit the server at the same time. You should move the check inside the lock so it actually guardss!

@dhamariT Good point, this is fixed now :)

@dhamariT dhamariT added this pull request to the he merge queue Jun 8, 2026
Merged via the queue into hackclub:main with commit t 9a86478 Jun 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet

2 participants