🗺 Add map #500
🗺 Add map #500
Conversation
|
well the only problem is the free tier is non-commercial use, maybe we could use leaflet |
How is Shipwrecked commercial use? Hack Club is a non-profit. Regarding Leaflet, it's already in use here. Leaflet doesn't provide map images, it only provides the software to display such images. |
|
How is Shipwrecked commercial use? Hack Club is a non-profit.
Regarding Leaflet, it's already in use here. Leaflet doesn't provide map images, it only provides the software to display such images..
oh yeah couldn't we use open street map though?
|
That was the original plan, but the Stadia Maps tiles look really nice and best fit the theme of Shipwrecked. Have you seen what the map looks like? I think most would agree. I don't see why this is such a big concern: it takes maybe 2 minutes to create an account and allow use on Shipwrecked domains. |
|
could you make it so only users tagged as "attending" could view the map? i'm happy to go mark everyone on bay |
|
Just want to comment here and add that this feature does not leak any PII. All users shown on the map have consented to share their information with other ShipWrecked attendees. As long as it's not public-public and is only accessible to people who are logged into the bay and has an auth wall, we're good to merge |
ShipwreckedPOI doesn't seem like it was checked in - therefore I am unable to test this locally.
Import trace for requested module:
./app/map/page.tsx
⨯ ./components/map/Map.tsx:12:1
Module not found: Can't resolve '@/components/map/ShipwreckedPOI'
10 | import Marker from '@/components/map/Marker';
11 | import Flight from '@/components/map/Flight';
> 12 | import ShipwreckedPOI from '@/components/map/ShipwreckedPOI';**
| ^
13 | import {latLng} from 'leaflet';
14 |
15 | export default function Map({theme, flights: flightsProp, center, setCenter}: {
https://nextjs.org/docs/messages/module-not-found
nd
e-not-found
|
@grymmy can you rereview cause you're blocking this rn |
|
personally im happy to just test this in staging |
EerierGosling
dismissed
grymmy’s stale review
it seems fixed and i want to test on staging
|
ok wait ignore me 😭 i figured out how to approve |
Adds a live map page to
/map.Most tracking features are only available when flights are actually in progress. For testing, I manually changed the dates in the Airtable so I could see the tracking features.
Two new environment variables are added, which are needed for the flight scraping API.
One last thing: map images are from Stadia Maps, which requires an account unless you are running on localhost. There is a free tier for non-commercial use, which is what I've been using.