Skip to content

Split Personality#3414

Merged
whatwareweb merged 12 commits intohackclub:mainfrom
ashmitiscodingpython:main
Nov 6, 2025
Lines changed: 815 additions & 0 deletionsions
Merged

Split Personality#3414
whatwareweb merged 12 commits intohackclub:mainfrom
ashmitiscodingpython:main

Conversation

@ashmitiscodingpython
Copy link
Contributor

@ashmitiscodingpython ashmitiscodingpython commented Nov 2, 2025 •
edited
Loading

Your checklist for this pull request

Author name

Author: Ashmit Jeevan

About your game

What is your game about?

Two player co-operate to reach the end.

How do you play your game?

WASD to move, K to restart/reset, J and L to switch players.

Code

Check off the items that are true.

  • The game was made using the Sprig editor.
  • The game is placed in the in the /games directory.
  • The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
  • The game runs without errors.
  • The name of the file/game contains only alphanumeric characters, -s, or _s.
  • The game name is not the same as the others from gallery
  • The game has metadata at the top of the file in the following format: 
    /*
@title:
@author:
@description:
@tags: []
@addedOn: 2025-MM-DD
*/
D
*/

Image (If an image is used)

Thanks for your PR!

Sorry, something went wrong.

@ashmitiscodingpython
Add Split Personality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
0d1c5c6
@ashmitiscodingpython
Add thumbnail for Split Personality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
34113e0
@ashmitiscodingpython
Update game metadata for Split Personality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
823b0a2
@ashmitiscodingpython
Rename Split Personality.PNG to Split_Personality.PNG

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
14a7524
@ashmitiscodingpython ashmitiscodingpython marked this pull request as draft November 2, 2025 15:37
@ashmitiscodingpython
Add Split Personality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
ea21ace
@ashmitiscodingpython ashmitiscodingpython marked this pull request as ready for review November 2, 2025 15:44
@whatwareweb
Copy link
Collaborator

whatwareweb commented Nov 2, 2025

Hello, please check our PR checklist here:

https://github.com/hackclub/sprig/blob/main/.github/PULL_REQUEST_TEMPLATE.md

Look at your metadata specifically. Thanks

@whatwareweb whatwareweb added the the triaged This PR has been triaged - awaiting reviewer label Nov 2, 2025
@ashmitiscodingpython
Edit metadata of Split Personality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
c2174f2
@ashmitiscodingpython
Copy link
Contributor Author

ashmitiscodingpython commented Nov 3, 2025

I've added the description to the metadata. Please let me know if there are any other errors.

@ashmitiscodingpython
Copy link
Contributor Author

ashmitiscodingpython commented Nov 4, 2025

@whatwareweb Can we continue with the review process?

@whatwareweb
Copy link
Collaborator

whatwareweb commented Nov 4, 2025

OK, just checked your metadata and it looks good. A reviewer will take a look at your game shortly. Thanks!

@whatwareweb whatwareweb added the the awaiting-review Preliminary metadata check is complete, awaiting. review! label Nov 4, 2025
@whatwareweb
Copy link
Collaborator

whatwareweb commented Nov 4, 2025

Hello, I love this game and the concept is really fun!! However, during the beginning levels, I am confused on how to play it, especially when one of the players has already made it to the end of the level but it restarts the game. Can you add some instructions in a comment at the top of your code to explain this to new players? Or also maybe make some tutorial levels with text explaining it. Thanks!

@whatwareweb whatwareweb self-assigned this Nov 4, 2025
@ashmitiscodingpython
Add Split Personality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
614d0d2
@ashmitiscodingpython
Delete games/Split_Personality.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
16ec61d
@ashmitiscodingpython
Update and rename Split Personality.js to Split_Personality.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
dc3b4d7
@ashmitiscodingpython
Update Split Personality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b228cb2
@ashmitiscodingpython
Copy link
Contributor Author

ashmitiscodingpython commented Nov 5, 2025

I've added a level that explains the controls. However, I did not understand what you meant by this: "especially when one of the players has already made it to the end of the level but it restarts the game."

@ashmitiscodingpython
Copy link
Contributor Author

ashmitiscodingpython commented Nov 5, 2025

@whatwareweb

@whatwareweb
Copy link
Collaborator

whatwareweb commented Nov 5, 2025 •
edited
Loading

On one of the levels, i brought one of the players to the goal but then it reset the level, not sure if it's a bug, but could you check on that or explain?

@ashmitiscodingpython
Copy link
Contributor Author

ashmitiscodingpython commented Nov 6, 2025

Can you specify which level?

@ashmitiscodingpython
Copy link
Contributor Author

ashmitiscodingpython commented Nov 6, 2025

@whatwareweb I'm sorry but I'm just an impatient kid

@whatwareweb
Copy link
Collaborator

whatwareweb commented Nov 6, 2025

ok i just tried again and that issue seems to be fixed, but now i have a new issue:
after you reset the level after getting one of the players to the goal, it will no longer let you switch players which will make the game freeze::
image

@ashmitiscodingpython
Delete games/Split_Personality.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b580077
@ashmitiscodingpython
Add Split Personality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
e741001
@ashmitiscodingpython
Copy link
Contributor Author

ashmitiscodingpython commented Nov 6, 2025 •
edited
Loading

K fixed it @whatwareweb

whatwareweb
whatwareweb approved these changes Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@whatwareweb whatwareweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks, this game looks good!

@whatwareweb
Copy link
Collaborator

whatwareweb commented Nov 6, 2025

Thanks for your submission!

If you're a teen, you can get your Sprig here! sprig-order.hackclub.dev

Hack Clubbers would love to see this! Just post a link and 1-2 sentences talking about your game to our #ship channel

@whatwareweb whatwareweb added this pull request to the he merge queue Nov 6, 2025
Merged via the queue into hackclub:main with commit t 3ae28f9 Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whatwareweb whatwareweb

Assignees

@whatwareweb whatwareweb

Labels

awaiting-review Preliminary metadata check is complete, awaiting. review! triaged This PR has been triaged - awaiting reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

2 participants

@ashmitiscodingpython @whatwareweb