feat(certification): add verdict preview confirmation modal#552
Conversation
| } | ||
| } | ||
|
|
||
| .verdict-preview { |
ngl this whole thing is reinventing stuff we already have. we got shared/_modal partial + the modal stimulus controller and it already does the dialog, backdrop click to close, esc, body scroll lock, all of it. ur new verdict_preview_controller.js is rewriting all that from scratch, and these ~175 lines of new css are basically redoing the .modal styles.
can u rip this out and reuse render "shared/modal" with the modal controller instead. stop writing new css for this, lean on the existing .modal class + the brand tokens for the verdict colors. should cut this PR down a ton. the only custom bit u actually need is the approve/reject preview content, not a whole new modal system
Drop the bespoke modal: reuse the shared .modal shell + modal controller (backdrop, esc, scroll-lock), .status-pill for the verdict badge, and .action-btn for the buttons. The verdict-preview controller now only builds the preview and re-submits on confirm. Removes ~163 lines of duplicate SCSS and ~60 lines of JS.f JS.
|
pushed a refactor to ur branch (6af38ac) doing what i said above. ripped out the custom modal + the ~175 lines of scss. now it reuses the shared net like +52 / -276. rubocop + erb lint clean, js builds. give it a click to make sure the approve/reject preview still looks right on ur end and lmk |
|
Everything looks great on my end I actually considered this approach at first, but I wasn't completely happy with how it looked. yeah, it does use less CSS, which is a nice thing. I think we can go with this for now and continue refining the styling (for the dash as a whole) in a separate PR if needed. |
2 participants
what's this do?
Adds a verdict preview modal for ship reviews, so shipwrights can confirm their decisions (approve/return)
show it works
ai?
Claude